Skip to content

fix(app-router): vary segment prefetches by accessed params #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
james-elicx wants to merge 7 commits into
base: main
Choose a base branch
from
+2,382 −61
Open

fix(app-router): vary segment prefetches by accessed params #2474

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
59376b9
fix(app-router): vary segment prefetches by accessed params
james-elicx Jul 1, 2026
35ef1e8
fix(app-router): detect props-based prefetch vary access
james-elicx Jul 1, 2026
600474c
fix(app-router): track aliased prefetch vary sources
james-elicx Jul 1, 2026
bfe151d
fix(app-router): tighten segment prefetch vary analysis
james-elicx Jul 1, 2026
4c56304
Merge remote-tracking branch 'origin/main' into HEAD
james-elicx Jul 1, 2026
d48f726
chore: format link prefetch merge resolution
james-elicx Jul 1, 2026
8e671bf
test(app-router): align prefetch merge expectations
james-elicx Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/vinext/src/client/vinext-next-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,26 @@
import type { NEXT_DATA } from "vinext/shims/internal/utils";
import { isUnknownRecord } from "../utils/record.js";

export type VinextRuntimePrefetchLoadingFallback = {
attributes: Record<string, string>;
tagName: string;
text: string;
};

export type VinextLinkPrefetchRoute = {
canPrefetchLoadingShell: boolean;
canPrefetchRuntimeShell?: boolean;
canPrefetchStaticRoute?: boolean;
documentOnly?: boolean;
isDynamic: boolean;
loadingShellVaryParamNames?: string[];
patternParts: string[];
prefetchVaryParamNames?: string[];
prefetchVarySearchParams?: boolean;
requiresDynamicNavigationRequest?: boolean;
runtimePrefetchLoadingFallback?: VinextRuntimePrefetchLoadingFallback;
runtimePrefetchVaryParamNames?: string[];
runtimePrefetchVarySearchParams?: boolean;
};

/**
Expand Down
Loading
Loading