fix(release): preserve authored changelog notes#2529
Closed
james-elicx wants to merge 1 commit into
Closed
Conversation
commit: |
Contributor
|
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changeset versionconsumes themauto-*.mdchangesets and SHA-named commit overrides to keep refreshes idempotentRoot cause
scripts/version.mtsreplaced each newly generated release section using only path-attributed conventional commits. Theenter-v1-beta.mdchangeset bumps@vinext/cloudflareand includes the beta announcement, but there are no post-0.2.1commits touchingpackages/cloudflare, so the rewrite replaced Changesets' output with an empty section.This is visible in #2499, where
@vinext/cloudflare@1.0.0-beta.0has no changelog body.Validation
vp check scripts/version.mts scripts/version.test.tsvp test run scripts/version.test.ts scripts/create-changeset.test.tsnode scripts/create-changeset.mtsthenGITHUB_REPOSITORY='' node scripts/version.mts@vinext/cloudflare@1.0.0-beta.0retainsRelease the first vinext 1.0 beta.vinext@1.0.0-beta.0retains the announcement plus accumulated conventional-commit groups