Add lifecycle_type column to apps, droplets, and builds#5065
Merged
Conversation
philippthun
force-pushed
the
lifecycle-type
branch
3 times, most recently
from
a2b3ec0 to
e107534
Compare
philippthun
force-pushed
the
lifecycle-type
branch
from
e107534 to
ecf03f8
Compare
philippthun
force-pushed
the
lifecycle-type
branch
from
ecf03f8 to
722342e
Compare
philippthun
changed the title
johha
reviewed
May 18, 2026
Store lifecycle_type directly on the model instead of deriving it from associated lifecycle data records. This simplifies queries and makes the lifecycle type explicit. - Add lifecycle_type column to apps, droplets, and builds tables - Set lifecycle_type in create actions (AppCreate, DropletCreate) - Add before_create hooks to builds/droplets to inherit from app - Add model validation for lifecycle_type values - Assign lifecycle_data back to model in lifecycle classes to ensure the in-memory association is set (avoids Sequel caching issues) - Add lifecycle type validation to DropletCopy - Update blueprints to set lifecycle_type explicitly - Fix shared example updated_at filtering to use allow_manual_update and explicit update instead of update_on_create: false - Replace inline timestamp workarounds with shared example usage in apps, droplets, and revisions request specs
philippthun
force-pushed
the
lifecycle-type
branch
from
722342e to
c25a9cf
Compare
johha
approved these changes
May 19, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 19, 2026
Changes in cloud_controller_ng:
- Add lifecycle_type column to apps, droplets, and builds
PR: cloudfoundry/cloud_controller_ng#5065
Author: Philipp Thun <philipp.thun@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store
lifecycle_typedirectly on the model instead of deriving it from associated lifecycle data records. This simplifies queries and makes the lifecycle type explicit.lifecycle_typecolumn to apps, droplets, and builds tableslifecycle_typein create actions (AppCreate,DropletCreate)before_createhooks to builds/droplets to inherit from applifecycle_typevalueslifecycle_databack to model in lifecycle classes to ensure the in-memory association is set (avoids Sequel caching issues)DropletCopylifecycle_typeexplicitlyupdated_atfiltering to useallow_manual_updateand explicit update instead ofupdate_on_create: falseI have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests