fix: validate ParentIDKey is non-empty in NewIndexer#953
Open
kuishou68 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Cocoon-Break <54054995+kuishou68@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #952
Problem
In
flow/indexer/parent/parent.go,NewIndexervalidatesIndexer,Transformer, andSubIDGeneratorfields but silently accepts an emptyParentIDKey. WhenParentIDKeyis empty,Store()silently writes every parent document ID to the""metadata key, making the parent-child relationship unresolvable for all consumers.Fix
Added a validation check for
config.ParentIDKey == ""inNewIndexer, consistent with the existing field validation pattern.Testing
Passing empty
ParentIDKeytoNewIndexernow returns an error at construction time instead of silently corrupting data at runtime.