Sharp Resharpening: Safety PR Split

[MPhonks]

About the pull request

This is a split of #11698 containing the safety-logic and QOL improvements to the P9 Sonic Harpoon Artillery Remote Projectile (SHARP) Rifle. It replaces the different firemode timers (2.5s, 5s, defaults to 2.5s) with a mine-safety toggle ("SAFE" mode).

Of the QOL changes are included:

• The ability to rearm previously disarmed mines (1s) as the SHARP specialist with a multitool
• The inability of mines to blow up to small xenomorph (facehuggers, lesser drones)
• The ability to see whether a mine has safety, and how long the mine lasts before being disarmed (specialist only)
• Automatic magazine ejection

Outside of the original PR, two new changes were were added:

• A square flameshape for level 2+ incendiary mines. (This made it possible to just copy-paste the safety logic, also introduces a new flameshape which is a neat bonus).
• The proposed bugfix from Explosion Waves: Visual update and Backend rewrite #12793, making SHARP mines deal their intended explosion damage in adjacent tiles.
• The bugfix inadvertedly made explosions one tile larger, which (with already large radii at levels 1+) counteracts the new safety feature. This is solved by clamping down SHARP mine explosions to mine_level tiles.

Explain why it's good for the game

As it stands right now, the SHARP contains fundamental design flaws. SHARP has been stamped off as a "xenoagent" role in the game which does more harm to the marine force than good. This PR does not aim to handhold the kit into becoming "the new meta", but rather addresses scenarios where the usage of the SHARP would be more helpful to aliens than to the marine force.

With SAFE mode, placing mines directly where marines walk and push becomes a reliable tool of both securing the backline and ensuring that marines do not suffer fatalities to the mines when pushed back. The mines refuse to detonate when anyone with IFF can be hurt by them, at the cost of potentially fizzling out when hitting xenomorphs directly, or missing out on kills from the potentially obtained stun they cause.

Testing Photographs and Procedure

Screenshots & Videos

See #11698 .

Changelog

🆑 MarpleJones
del: SHARP timer modes (5s, 2.5s) removed, default at 2.5s
add: adds SHARP safety mode, which has greater IFF logic and prevents the mine from detonating when near friendlies.
add: you can now rearm SHARP mines as the SHARP specialist with a security access tuner (multitool)
add: adds a security access tuner to the specialist kit
add: small xenomorph no longer trigger sharp mines
add: square fireshape
balance: incendiary mines are now strictly square
balance: bugfix to explosion wave calculation; intended damage is now dealt to adjacent tiles
balance: clamps mine explosions to mine_level
qol: firemodes as a specialist ability, extended description for mine timers and modes, magazine autoejection
/:cl:

[cmss13-ci]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[fira]

I assume you meant /turf/open_space rather than /turf/open/space, both are very different things!

[MPhonks]

Copied it from the other flameshape codes. :P (Could change it if it's an issue, although I didn't notice any impact)