Fix: Custom Hotkeys replacing + with Add - #12896
Open
MistChristmas wants to merge 1 commit into
Open
Conversation
cmss13-ci
Bot
added
UI
MistChristmas
changed the title
+ with Add + with Add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
We don't want to do the above cause We need the + to join stuff for the key combos to work.
So I faff around with the key and mod params, giving it to the custom keybind stuff.
Turn the joining into a proc so we don't accidently include replacing the joining character with the keyboard map.
I forgot to record it but it also fixes
The ARROWUP
Becoming ArrowNorth instead of North etc.
Explain why it's good for the game
Probably a good idea to have our keybind stuff working...
Testing Photographs and Procedure
Screenshots & Videos
Testi-Hotkeys.0236-10-08.1.mp4
Changelog
🆑
fix: Custom Hotkeys saving + as Add, and ARROWUP not being saved as North etc for the arrow keys.
/:cl: