fixes minimap crash when traversing z level inside of an object - #12911
Open
cuberound wants to merge 2 commits into
Open
fixes minimap crash when traversing z level inside of an object#12911cuberound wants to merge 2 commits into
cuberound wants to merge 2 commits into
Conversation
cmss13-ci
Bot
added
Fix
fira
reviewed
Aug 13, 2026
fira
left a comment
fira
left a comment
Member
There was a problem hiding this comment.
I think this should just not be called at all and checked for in on_z_change instead. it doesn't make sense that it calls oldloc = null when it's incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
fixes the crash when traversing z level inside of bodybag or multiz pipe. I could not find any inconsistency caused by removing this part of code. checked that moving people in bags still updates them on minimap
Explain why it's good for the game
fixes crash on pipes and bags
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: fixes runtime caused by crossing z levels using pipes and bodybags
/:cl: