[WIP] sstable: enable compression levels#4513
Draft
EdwardX29 wants to merge 1 commit into
Draft
Conversation
Member
3dc71b4 to
7fdb372
Compare
Enable compression levels by changing block.Compression to be composed of a Family and Level. Expose new enums to Cockroach.
7fdb372 to
a2b7d52
Compare
RaduBerinde
reviewed
Apr 9, 2025
RaduBerinde
left a comment
Member
There was a problem hiding this comment.
Reviewable status: 0 of 19 files reviewed, 2 unresolved discussions (waiting on @jbowens)
sstable/block/compression.go line 86 at r1 (raw file):
var DefaultCompression = Compression{Family: DefaultCompressionFamily, Level: LevelDefault} var NoCompression = Compression{Family: NoCompressionFamily, Level: LevelDefault} var SnappyCompression = Compression{Family: SnappyCompressionFamily, Level: LevelDefault}
We should use ZstdLevelDefault, etc.
options.go line 54 at r1 (raw file):
// Zstd compression levels. ZstdCompressionLevel1 = block.Compression{Family: block.ZstdCompressionFamily, Level: block.ZstdLevel1}
I don't think level should be an enum.. It's always integers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable compression levels by changing block.Compression to be composed of a Family and Level. Expose new enums to Cockroach.