Skip to content

[codex] Separate commercial distribution from Core - #120

Merged
danieliser merged 8 commits into
developfrom
feat/wporg-distribution-separation
Aug 19, 2026
Merged

danieliser merged 8 commits into
developfrom
feat/wporg-distribution-separation

Conversation

@danieliser

@danieliser danieliser commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Issue and user impact

Commercial distribution code lived in public Core, but released Content Control Pro versions still depend on Core's license provider and updater key. Removing every shared path at once would make a Core-first rollout break Pro licensing and authenticated updates.

The mixed-version state must remain usable in either release order. The next Core release with active Pro below 1.3.0 keeps license management and authenticated Pro updates while exposing no installer, connection, or webhook behavior. Customers install Pro manually until Pro 1.3.0 is available.

Fix

  • Removes Core's connection, webhook/AJAX, package upgrader, and silent installer implementations.
  • Retains a version-gated license-only provider and license field for active Pro versions below 1.3.0.
  • Keeps activate, deactivate, delete, status refresh, and authenticated update behavior available to those Pro versions.
  • Unregisters the installer endpoint contributed by active Pro below 1.3.0 before it can resolve Core's removed upgrader service; the guard is deprecated in Core 2.7.0 for removal when Pro 1.3.0 becomes the minimum supported version.
  • Leaves Core alone, inactive Pro, and Pro 1.3.0+ without the Core-owned license surface.
  • Replaces the repository-specific source blacklist with a generic release-boundary verifier and WordPress Plugin Check, matching Popup Maker's current organization.
  • Updates release workflows and the metadata required by Plugin Check without advancing release-time version fields.

Compatibility matrix

  • New Core alone: no commercial license/install UI or routes.
  • New Core + old Pro: license field and authenticated Pro updates remain functional; Pro installation is manual; add-on installation is unavailable.
  • Old Core + new Pro: Pro replaces Core callbacks and owns licensing/distribution.
  • New Core + new Pro: Core's bridge remains dormant and Pro owns the full commercial path.

Validation

  • Production Core build passed.
  • Generic release-tree verification passed: 183 entries.
  • Actual release ZIP verification passed: 227 entries.
  • Artifact verifier Jest suite passed: 6 tests.
  • Focused compatibility PHPUnit suite passed: 2 tests, 6 assertions.
  • WordPress Plugin Check passed against the assembled plugin with no errors.
  • PHP Code Sniffer and PHP static analysis pass in CI.
  • git diff --check passed.

The repository-wide TypeScript/lint commands still expose pre-existing toolchain debt: TypeScript 6 rejects the existing deprecated moduleResolution=node10/esModuleInterop=false configuration, and the package lint command reports existing resolver/global/type parsing errors throughout the settings package.

Related PRs

  • Pro ownership: code-atlantic/content-control-pro#1
  • Teasers updater registration: code-atlantic/content-control-teasers#1
  • Previews updater registration: code-atlantic/content-control-previews#1

@coderabbitai

coderabbitai Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8caab4e8-c992-4c7b-817e-f71756a445c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danieliser
danieliser marked this pull request as ready for review August 19, 2026 09:11
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@danieliser
danieliser merged commit 713dc81 into develop Aug 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant