[pull] release from appsmithorg:release#264
Merged
Merged
Conversation
…LOBSTAR (fixes storybook) (#41949) ## Problem `storybook-tests` fails. There are two independent layers, both fixed here. ### Layer 1 — `GLOBSTAR` build failure The Storybook preview build fails with: `SyntaxError: The requested module 'minimatch' does not provide an export named 'GLOBSTAR'` **Root cause:** the `resolutions` block in `app/client/package.json` had an over-broad blanket `"minimatch": "^5.1.8"` that force-downgraded *every* minimatch to 5.x — including `glob@10` / `glob@11` (ESM), which require minimatch 9/10 for the `GLOBSTAR` named export. **Fix:** replaced the blanket with the specific `minimatch@^3.x -> ^5.1.8` pins (the CVE-2022-3517 ReDoS remediation, including the exact `3.0.4` consumer). Resulting resolution: - `glob@11 -> minimatch 10.2.5`, `glob@10 -> 9.0.9` (GLOBSTAR export present) - `glob 7/8 -> 5.1.9` (unchanged) - all minimatch `>= 3.0.5` (no CVE regression — a bare blanket removal would have reintroduced vulnerable `3.0.4`, which these pins prevent) ### Layer 2 — test-runner OOM Once the build works, `test-storybook:ci` runs the Jest + Playwright test-runner, which exceeds Node's ~2GB default old-space heap and dies with `JavaScript heap out of memory` (exit 129). Added `NODE_OPTIONS=--max-old-space-size=8192` to the Storybook Tests step. ## Verification (local, Node 24) - `yarn install --immutable` clean - Resolved minimatch all `>= 3.0.5` (no vulnerable version) - Storybook builds clean (no `GLOBSTAR` error), `storybook-static` artifact produced - `glob 7/8` (used by the webpack client build) unchanged, so the client build is unaffected ## Context The identical fix landed in the EE repo (`appsmith-ee`) to unblock its CI; the blanket resolution is identical in CE, so CE's Storybook is broken the same way. Landing it here makes the fix durable (the CE->EE sync converges the two) and fixes CE's own Storybook. **Merge with a merge commit — do not squash** (preserves CE<->EE sync history). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Automation /ok-to-test tags="@tag.All" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Increased the memory limit for Storybook tests in CI to help them run more reliably. * Updated dependency resolution settings to keep compatible versions of a transitive package pinned consistently. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/28718473128> > Commit: 9fc1f09 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=28718473128&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Sat, 04 Jul 2026 21:26:14 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )