[pull] master from mattermost:master#810
Merged
Merged
Conversation
…l permission rule (#37234) * Fix Upload Files pre-selected when creating a new channel permission rule The new-rule editor seeded the draft with the Upload Files action selected. New rules should start with no permissions selected. Co-authored-by: mattermost-code <matty-code@mattermost.com> * Add tests for channel permission rule editor default permissions Covers the regression guard that a new rule starts with no permissions selected, and that existing rules preserve their selected permissions. Co-authored-by: mattermost-code <matty-code@mattermost.com> * Strengthen permission rule editor tests per review Scope the dropdown assertion to option descriptions so it can't pass against a pre-selected table row, and add a validation test covering the now-reachable empty-permissions save path. Co-authored-by: mattermost-code <matty-code@mattermost.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
* Fix permission policy rule editor defaulting to advanced mode The permission policy rule editor used a stale, divergent local copy of isSimpleExpression that did not recognize parenthesized multiselect "has any of" OR-groups or ranked-operator conditions as simple. Such rules were misclassified as complex, so editing them opened the advanced (CEL) editor instead of the simple table editor. Use the shared isSimpleExpression helper (already used by the membership policy editor) so the same set of simple expressions is recognized consistently. Co-authored-by: mattermost-code <matty-code@mattermost.com> * Add regression tests for permission policy editor default mode Cover MM-69527: editing an existing permission policy rule must default to Simple (table) mode for every expression the simple editor can represent, including multiselect "has any of" OR-groups and ranked operators. Complex expressions still open in Advanced (CEL) mode. Co-authored-by: mattermost-code <matty-code@mattermost.com> * ci: re-trigger CodeRabbit review Co-authored-by: mattermost-code <matty-code@mattermost.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )