[pull] master from mattermost:master#814
Merged
Merged
Conversation
#37345) * [MM-69688] Fix /share-channel status Last Sync always showing -- GetRemotesStatus never selected the sync cursor columns, so SharedChannelRemoteStatus.NextSyncAt was always the zero value and formatTimestamp rendered "--". Select GREATEST of the LastPostUpdateAt and LastMembersSyncAt cursors as LastSyncAt and render that field. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69688] Cover LastSyncAt in GetRemotesStatus store test Advance the post and members sync cursors and assert GetRemotesStatus reports LastSyncAt as the greater of the two, and reports zero when a remote has never synced. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69688] Add command and formatTimestamp coverage for Last Sync Add doStatus command-layer tests asserting the /share-channel status output renders a timestamp for a synced remote and "--" for an unsynced one, a formatTimestamp unit test for the zero/today/older branches, and harden the store test so both GREATEST operands are non-zero. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69688] Assert the non-today timestamp format in formatTimestamp test Co-authored-by: mattermost-code <matty-code@mattermost.com> * Trigger CI re-run after transient Postgres shard 3 Docker Hub failure Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69688] Include LastPostCreateAt in Last Sync computation --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )