[pull] master from mattermost:master#815
Merged
Merged
Conversation
…te clusters (#37346) * [MM-69689] Self-heal orphaned shared channel remotes for deleted remote clusters When a SharedChannelRemote row is still live (DeleteAt = 0) but its RemoteCluster has been soft-deleted, the sync loop repeatedly picks up the orphaned row and logs a warning on every tick without ever cleaning it up. Soft-delete the orphaned SharedChannelRemote when the remote cluster lookup returns sql.ErrNoRows, so the row stops recurring in the sync loop. Logs a Warn (not Error) and skips the task. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69689] Expand self-heal test coverage for orphaned shared channel remotes Add subtests covering the DeleteRemote failure branch and an end-to-end doSync run proving a self-healed orphan is drained and not retried, and assert DeleteRemote call counts. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69689] Log already-deleted remote skip at debug instead of warn A soft-deleted RemoteCluster no longer syncing is the expected steady state, so skipping it does not warrant a warning. Downgrade the log for the already-soft-deleted SCR case to debug to avoid noise. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )