[pull] master from mattermost:master#816
Merged
Merged
Conversation
… header (#37347) * [MM-69691] Fix /secure-connection status table sorting and header Sort deleted connections to the bottom (active first, ordered by CreateAt within each group) and remove the spurious empty cell from the Markdown table header separator so it has 9 cells matching the header and data rows. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69691] Add test for /secure-connection status output Verifies deleted connections sort to the bottom (active first, ordered by CreateAt within each group) and that the Markdown table header separator has exactly nine cells matching the columns. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69691] Strengthen /secure-connection status test assertions Assert the separator row equals the exact nine-cell string and has nine alignment cells, verify data rows have nine cells, and cover CreateAt ordering (overriding alphabetical) plus stable ordering for equal CreateAt within a group. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69691] Use strings.SplitSeq in status test to satisfy linter Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69691] Retrigger CI after buildenv artifact infra failure Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69691] Retrigger Enterprise CI after npm ECONNRESET flake Co-authored-by: mattermost-code <matty-code@mattermost.com> * Add missing return in doStatus error path Address review feedback from @wiggin77: the error branch in doStatus built an error response but discarded it, so execution fell through to the empty-list check on a nil list. Return the response instead. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )