[pull] master from mozilla:master#443
Merged
Merged
Conversation
…ters escapePDFName emitted a single hex digit for character codes below 0x10 (TAB became #9, not #9). PDF 32000-1 7.3.5 requires exactly two hex digits after #. On re-save (annotations, form fields, font names) such a Name is written malformed and the lexer mis-parses it on reload, dropping bytes. Pad the hex to two digits; a no-op for codes 0x10 to 0xFF.
…w-up) - Replace the `loadFromDocument` and `reset` methods with a single `setDocument` method, since that's consistent with many other viewer components. - Replace the internal `#loadToken` field with simple `pdfDocument` checks, when checking if the document is still current, which again is consistent with (all) other viewer components. - Remove a couple of comments, which didn't add a lot of value and sounded a whole lot like "AI speak".
Fix escapePDFName producing malformed name escapes for control characters
…er-setDocument A couple of `SignaturePropertiesManager` improvements (PR 21247 follow-up)
Serialize GitHub Pages deployments to avoid concurrent deploy failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )