[pull] master from mozilla:master#447
Merged
Merged
Conversation
encodeToXmlString skips surrogate pairs with the guard `char > 0xd7ff && (char < 0xe000 || char > 0xfffd)` and then does `i++` to step over the low surrogate. That predicate is also true for U+FFFE and U+FFFF, which are single UTF-16 code units, not surrogate pairs. The `i++` then skips the character that follows them, so it is silently dropped. For example, encodeToXmlString of U+FFFF followed by "A" returned "" instead of "A". The function serializes XML text nodes and attribute values in xml_parser.js and xfa_object.js, so this corrupts round-tripped XML and XFA content. The correct test for a surrogate pair is `char > 0xffff`, since codePointAt returns a value at or above 0x10000 only for a real pair. This preserves the existing behavior for emoji, the U+FFFD boundary, and lone surrogates, and stops dropping the character after U+FFFE and U+FFFF.
…ment.js` Given that this is the *initial value* of the field, setting it again when no signatures exist is pointless.
Do not drop the character after U+FFFE or U+FFFF in encodeToXmlString
…t-operators Enable the unicorn/logical-assignment-operators ESLint plugin rule
…signatureData-null Remove unneeded `this.#signatureData = null;` lines in `src/core/document.js`
Use the `MathClamp` helper in the `PDFImage.prototype.getComponents` method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )