[pull] develop from baserow:develop#341
Merged
Merged
Conversation
…60s limit (#5614) * fix(backend): set hard time_limit on tasks that inherit the default 360s limit schedule_update_search_data, schedule_ai_field_generation and run_async_job declared no hard time_limit, so they inherited the global 360s default and were killed mid-run on large workloads. Give each an explicit hard limit sized to its real work, with the soft limit firing first. Fixes BASEROW-SAAS-BACKEND-3Z * Address PR review feedback (#5614) - Clamp soft_time_limit to max(1, hard - 30) on the search and AI-field scheduling tasks so a misconfigured hard limit <= 30s can't break task registration at worker startup - Remove the now-redundant inline comments explaining the explicit limits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )