[pull] develop from baserow:develop#345
Merged
Merged
Conversation
…dmin (#5625) * fix(core): only delete workspaces where a deleted user was the last admin delete_expired_users_and_related_workspaces_if_last_admin scanned every workspace and deleted any with no non-deleted admin, so an admin-less workspace unrelated to the users being deleted was wrongly removed. Restrict the candidates to workspaces where one of the deleted users was actually an admin (Exists subquery), keeping the existing 'no active admin left after deletion' check. * chore(core): address review feedback Fix comment grammar and materialize id querysets to sets in the workspace-deletion regression test.
…ember's role (#5627) Accepting an invitation went through add_user_to_workspace, which did a blind update_or_create that overwrote an existing member's permissions. A user could invite an email as MEMBER, change their own account email to it, then accept — demoting themselves and potentially leaving the workspace without an admin. Make add_user_to_workspace idempotent via get_or_create so an existing member's role is never overwritten, and emit workspace_user_added only on actual creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )