[pull] develop from baserow:develop#349
Merged
Merged
Conversation
* feat(database): add starts with view filter type Adds a new "starts_with" view filter that keeps rows whose field value begins with the filter value (case-insensitive), with both backend and web-frontend implementations including the real-time row-match check. Supported field types: text, long text, url, email, phone number, number, autonumber, single select, and text/char/url/number/single_select formulas. Closes #1943 * test(web-frontend): update view filter form snapshot for starts with filter * fix(database): address review feedback on starts with filter - Use toSearchableString in the frontend startsWithFilter so real-time matching stays consistent with the backend for formatted number fields; delegate FormulaFieldType.startsWithFilter to the underlying field type so number/select formulas stay consistent too - Don't trim the row value in genericStartsWithFilter (backend only strips the filter value, not the stored cell), avoiding leading-whitespace divergence - Fix misleading docstrings on StartsWithViewFilterType and starts_with_query - Add backend coverage for a non-text (number) formula and a frontend test for a formatted number field - Link changelog entry to issue #1943 * fix(database): delegate starts_with filter on AI fields Address review feedback on PR #5624: - Delegate starts_with_query / getStartsWithFilterFunction on the premium AIFieldType so AI fields filter correctly instead of silently matching every row (backend Q() / frontend () => false fallthrough). - Add backend and frontend regression tests for the AI-field gap. - Remove the unreachable FormulaFieldType.getStartsWithFilterFunction. - Rename genericStartsWithFilter's second arg to searchableRowValue. - Trim the StartsWithViewFilterType docstring to its behavioral sentence. * docs(database): note starts_with compatibility via get_compatible_filter_field_type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )