[pull] develop from baserow:develop#355
Merged
Merged
Conversation
* fix: group-by grid view review follow-ups Address deferred review discussions from #5470 and #5602: - Grouped grid refresh no longer blanks the grid before fetching. The plain-refresh path builds the new grouped state in a snapshot and swaps it in atomically (refreshActiveGroupBys gains a preserveScroll flag), matching the flat grid's fetch-then-swap and keeping the scroll position. - Right-clicking a group's add-row button now opens the "add N rows" menu, seeding each new row with the group's values (new createNewRowsInGroup action). - Grouped cell selection clears the previous selection in O(1) via rowLocations and a tracked selectedRowId, instead of scanning every loaded row. * fix: address feedback
* fix(database): improve escaping of URLs and user input Escape user-provided select option values and colors when building the database API documentation, and restrict URL, link and button field cell hrefs to a safe scheme allowlist so non-navigable values are normalised. Add unit tests for the URL scheme helpers and the select option docs output. * fix(database): keep url hrefs working for string and protocol-relative values Restore hrefs for URL lookup/array cells whose value is a plain string, and prefix protocol-relative `//` URLs with `https:` instead of `https://`. Add changelog entry. * fix: address feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )