Skip to content

refactor: escape --host in spark serve to prevent CLI command injection #10156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgInnora wants to merge 2 commits into
base: develop
Choose a base branch
from
+104 −1
Open

refactor: escape --host in spark serve to prevent CLI command injection #10156

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
142090a
security: escape $host in spark serve to prevent CLI command injection
sgInnora May 4, 2026
d9a9ea4
refactor: combine host:port into a single escapeshellarg() and add Se…
sgInnora May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/Commands/Server/Serve.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public function run(array $params)
{
// Collect any user-supplied options and apply them.
$php = escapeshellarg(CLI::getOption('php') ?? PHP_BINARY);
$host = CLI::getOption('host') ?? 'localhost';
$host = escapeshellarg(CLI::getOption('host') ?? 'localhost');
$port = (int) (CLI::getOption('port') ?? 8080) + $this->portOffset;

// Get the party started.
Expand Down