Open
Conversation
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-authored-by: Mux <noreply@coder.com>
5c3dcca to
f5496ca
Compare
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds bulk-delete actions for sidebar variant groups and fixes the Nix dev shell/static formatting path so local validation includes the required formatter/linkcheck tools.
Background
Variant task groups were collapsed into a single sidebar row, but deleting the whole set required expanding the group and deleting variants one by one. While validating the change, the Nix dev shell could not evaluate because current nixpkgs removed
mdbook-linkcheck, andfmt-nix-checkattempted to runnix fmtfrom a temp directory without flake metadata.Implementation
mdbook-linkcheckpackage withmdbook-linkcheck2in the dev shell.nix fmt -- --check flake.nixinstead of evaluating a temp-copy flake.Validation
bun test src/browser/components/ProjectSidebar/ProjectSidebar.test.tsxnix develop --command make fmt-checknix develop --command make static-checkRisks
Low-to-medium risk. The UI change is scoped to coalesced variant group rows and uses the existing workspace removal path, but deleting a full variant group is destructive by design and relies on the existing confirmation/force-delete behavior.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$0.00