🤖 refactor: simplify compaction notification tests#3269
Conversation
|
@codex review Please review this follow-up simplification PR, especially the removal of dead ContinueMessage helpers and the refactored compaction/notification test fixtures. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 106ea5b802
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
106ea5b to
32b17df
Compare
|
@codex review Addressed the mobile build issue by removing the stale mobile import of the deleted helper and verified mobile tests locally. |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Simplifies the notification/compaction follow-up test surface after #3261 by removing dead
ContinueMessagefactory code and replacing repeated AgentSession/WorkspaceStore scenario setup with focused fixtures. Net diff removes 1,091 lines while preserving the behavioral coverage for post-compaction notification suppression, background handoffs, queued follow-ups, and legacy pending-follow-up recovery.Background
#3261 intentionally localized notification policy in the browser aggregator. This follow-up keeps that behavior intact but trims older helper code and test boilerplate that made the related compaction/notification paths harder to review.
Implementation
ContinueMessagebuilder/rebuilder types and their standalone tautological tests; repo search found no production callsites.agentSession.continueMessageAgentId.test.tsaround a shared AgentSession/history harness and semantic compaction-summary fixtures.WorkspaceStore.test.tsbackground completion scenarios around activity/stream event fixture helpers.ContinueMessagehelper.Validation
bun test src/browser/stores/WorkspaceStore.test.ts src/node/services/agentSession.continueMessageAgentId.test.ts src/browser/utils/messages/StreamingMessageAggregator.test.ts src/browser/utils/chatCommands.test.tsmake static-checkRisks
Low. Production change is limited to deleting unused common-message helper exports. Test refactors keep the same behavioral scenarios but centralize repeated fixture construction, so the main risk is fixture abstraction hiding a future scenario mismatch.
Generated with
mux• Model:openai:gpt-5.5• Thinking:high• Cost:$66.83