Refactor: move all icons to common components - #445
Open
ramiy wants to merge 1 commit into
Open
Conversation
ramiy
changed the title
Contributor
Author
|
We can merge this to 3.10, but we don't have to. It can also wait for 4.0. |
Member
|
Happy to include this in 3.10, but I am curious – what is the benefit of keeping each icon in its own file? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split grouped icon files into single-icon files. This change consolidate every icon into
src/js/components/common/icons/, one file per icon (no grouping).Also, all the icons are now have the same type, and they all accept props to allow custom size and styling.