fix(python): remove nest_asyncio dependency for Python 3.12+ compatibility#639
Closed
Kubudak90 wants to merge 1 commit into
Closed
fix(python): remove nest_asyncio dependency for Python 3.12+ compatibility#639Kubudak90 wants to merge 1 commit into
Kubudak90 wants to merge 1 commit into
Conversation
…ility Remove nest_asyncio which is unmaintained and incompatible with Python 3.12+'s loop_factory parameter. This fixes compatibility issues with modern uvicorn and other async libraries that use loop_factory. Fixes coinbase#591
🟡 Heimdall Review Status
|
Author
|
Closing in favor of #637 which has a more comprehensive solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dependency from the Python SDK, which is no longer needed for Python 3.12+ compatibility.
Changes
Rationale
The library was previously used to enable nested event loops, but this is no longer necessary with modern Python async patterns. Removing it reduces dependencies and potential compatibility issues.
Testing
Fixes potential compatibility issues with Python 3.12+