fix: make nest_asyncio optional for Python 3.12+ compatibility#640
Closed
Kubudak90 wants to merge 1 commit into
Closed
fix: make nest_asyncio optional for Python 3.12+ compatibility#640Kubudak90 wants to merge 1 commit into
Kubudak90 wants to merge 1 commit into
Conversation
nest_asyncio is incompatible with Python 3.12+ due to its patched asyncio.run() not supporting the loop_factory parameter used by modern uvicorn. Changes: - Make nest_asyncio import and apply() optional with proper error handling - Skip nest_asyncio for Python 3.12+ to avoid breaking loop_factory support - Update _run_async() to handle both nested and non-nested loop scenarios Fixes coinbase#591
🟡 Heimdall Review Status
|
Author
|
Closing in favor of #637 which has a more comprehensive solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #591
nest_asyncio is incompatible with Python 3.12+ because its patched
asyncio.run()doesn't support theloop_factoryparameter used by modern uvicorn and other async frameworks.Problem
When using Python 3.12+ with uvicorn, importing
cdptriggersnest_asyncio.apply()which patchesasyncio.run. This breaks uvicorn's server startup which requires theloop_factoryparameter.Error:
Solution
nest_asyncioimport andapply()optional with proper error handlingnest_asynciofor Python 3.12+ to preserveloop_factorysupport_run_async()to handle both nested and non-nested loop scenarios gracefullyChanges
python/cdp/evm_local_account.py:Testing