fix(python): remove nest-asyncio dependency for Python 3.12+ compatibility#651
Open
Kubudak90 wants to merge 1 commit into
Open
fix(python): remove nest-asyncio dependency for Python 3.12+ compatibility#651Kubudak90 wants to merge 1 commit into
Kubudak90 wants to merge 1 commit into
Conversation
…ility Replace nest_asyncio with a thread-safe _run_async fallback that uses ThreadPoolExecutor when called from an already-running event loop. This restores compatibility with Python 3.12+ and uvicorn. Fixes coinbase#591
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #591.
Removes the "nest-asyncio" dependency and replaces it with a thread-safe fallback in .
Problem
is incompatible with Python 3.12+ in environments using or other modern async loops, causing runtime errors when synchronous methods on are called from an already-running event loop.
Solution
If no event loop is running, uses directly.
If an event loop is already running, the coroutine is executed in a background thread, where can safely create a new loop.
This approach is standard, does not require patching the event loop, and works correctly across all supported Python versions.
Changes
Testing