Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions resources/tax_type/ca_ab_gst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"name": "Canada - Alberta",
"generic_label": "GST",
"display_inclusive": false,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this is the default I'd suggest just removing it from all the json files (most of the others do it this way)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion :)

I'll have that done.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'd submit a pull request with your changes but it makes a new PR and would prefer if I could help on yours magically. (new to contrib on github)

"zone": "ca_ab_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why VAT in the zone?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the PR for Canadian Sales Tax as that term is never used in Canada.

"tag": "CA",
"rates": [
{
"id": "ca_ab_gst_standard",
"name": "Standard",
"default": true,
"compound": true,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be FALSE? as Alberta doesn't have PST or is it to go with other taxes? If it should be TRUE then I think we need to do this to the ca_bc_gst too?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, seems to me it should be false.

"amounts": [
{
"id": "ca_ab_gst_standard_2013",
"amount": 0.05,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_bc_gst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - British Columbia",
"generic_label": "GST",
"display_inclusive": false,
"zone": "ca_bc_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",
"rates": [
{
"id": "ca_bc_gst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_bc_gst_standard_2013",
"amount": 0.05,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_bc_pst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - British Columbia",
"generic_label": "PST",
"display_inclusive": false,
"zone": "ca_bc_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",
"rates": [

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should
"compound": true,
be added?

{
"id": "ca_bc_pst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_bc_pst_standard_2013",
"amount": 0.07,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_mb_gst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Manitoba",
"generic_label": "GST",
"display_inclusive": false,
"zone": "ca_mb_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should
"compound": true,
be added?

"rates": [
{
"id": "ca_mb_gst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_mb_gst_standard_2013",
"amount": 0.05,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_mb_pst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Manitoba",
"generic_label": "PST",
"display_inclusive": false,
"zone": "ca_mb_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should
"compound": true,
be added?

"rates": [
{
"id": "ca_mb_pst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_mb_pst_standard_2013",
"amount": 0.08,
"start_date": "2013-04-01"
}
]
}
]
}
22 changes: 22 additions & 0 deletions resources/tax_type/ca_nb_hst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"name": "Canada - New Brunswick",
"generic_label": "HST",
"display_inclusive": false,
"zone": "ca_nb_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",
"compound": false,
"rates": [
{
"id": "ca_nb_hst_standard",
"name": "hst",
"default": true,
"amounts": [
{
"id": "ca_nb_hst_standard_2013",
"amount": 0.13,
"start_date": "2013-04-01"
}
]
}
]
}
27 changes: 27 additions & 0 deletions resources/tax_type/ca_nl_hst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"name": "Canada - Newfoundland and Labrador",
"generic_label": "HST",
"display_inclusive": false,
"zone": "ca_nl_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",
"rates": [
{
"id": "ca_nl_hst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_nl_hst_standard_2013",
"amount": 0.13,
"start_date": "2013-04-01",
"end_date": "2015-12-31"
},
{
"id": "ca_nl_hst_standard_2016",
"amount": 0.15,
"start_date": "2016-01-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_ns_hst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Nova Scotia",
"generic_label": "HST",
"display_inclusive": false,
"zone": "ca_ns_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",
"rates": [
{
"id": "ca_ns_vat_standard",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change to ca_ns_hst_standard to be consistent, and to get rid of vat.

"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_ns_vat_standard_2013",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change to ca_ns_hst_standard_2013 to be consistent, and to get rid of vat.

"amount": 0.15,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_nt_hst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Northwest Territories",
"generic_label": "GST",
"display_inclusive": false,
"zone": "ca_nt_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",
"rates": [
{
"id": "ca_nt_gst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_nt_gst_standard_2013",
"amount": 0.05,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_nu_gst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Nunavut",
"generic_label": "GST",
"display_inclusive": false,
"zone": "ca_nu_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",
"rates": [
{
"id": "ca_nu_gst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_nu_gst_standard_2013",
"amount": 0.05,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_on_hst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Ontario",
"generic_label": "HST",
"display_inclusive": false,
"zone": "ca_on_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",
"rates": [
{
"id": "ca_on_hst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_on_hst_standard_2013",
"amount": 0.13,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_pe_hst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Prince Edward Island",
"generic_label": "HST",
"display_inclusive": false,
"zone": "ca_pe_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",
"rates": [
{
"id": "ca_pe_hst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_pe_hst_standard_2013",
"amount": 0.14,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_qc_gst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Quebec",
"generic_label": "GST",
"display_inclusive": false,
"zone": "ca_qc_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should
"compound": true,
be added?

"rates": [
{
"id": "ca_qc_gst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_qc_gst_standard_2013",
"amount": 0.05,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_qc_qst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Quebec",
"generic_label": "QST",
"display_inclusive": false,
"zone": "ca_qc_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should
"compound": true,
be added?

"rates": [
{
"id": "ca_qc_qst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_qc_qst_standard_2013",
"amount": 0.09975,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_sk_gst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Saskatchewan",
"generic_label": "GST",
"display_inclusive": false,
"zone": "ca_sk_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should
"compound": true,
be added?

"rates": [
{
"id": "ca_sk_gst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_sk_gst_standard_2013",
"amount": 0.05,
"start_date": "2013-04-01"
}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_sk_pst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Saskatchewan",
"generic_label": "PST",
"display_inclusive": false,
"zone": "ca_sk_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should
"compound": true,
be added?

"rates": [
{
"id": "ca_sk_pst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_sk_pst_standard_2013",
"amount": 0.05,
"start_date": "2013-04-01"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably be excluded? It's been 0.05 since October 28, 2006 http://finance.gov.sk.ca/taxes/pst/

}
]
}
]
}
21 changes: 21 additions & 0 deletions resources/tax_type/ca_yt_gst.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Canada - Yukon",
"generic_label": "GST",
"display_inclusive": false,
"zone": "ca_yt_vat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

"tag": "CA",
"rates": [
{
"id": "ca_yt_gst_standard",
"name": "Standard",
"default": true,
"amounts": [
{
"id": "ca_yt_gst_standard_2013",
"amount": 0.05,
"start_date": "2013-04-01"
}
]
}
]
}
13 changes: 13 additions & 0 deletions resources/zone/ca_ab_vat.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to rename to remove vat

"name": "Canada - Alberta (GST)",
"scope": "tax",
"members": [
{
"type": "country",
"id": "ca_ab_vat_0",
"name": "Canada - Alberta",
"country_code": "CA",
"administrative_area": "CA-AB"
}
]
}
Loading