-
Notifications
You must be signed in to change notification settings - Fork 43
Add Canadian taxes #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
7f0fffe
c1bd481
16312ba
a6313c5
201abc9
e4c6f5c
918e8b6
65ff413
1b7cb37
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "name": "Canada - Alberta", | ||
| "generic_label": "GST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_ab_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why VAT in the zone? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the PR for Canadian Sales Tax as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "rates": [ | ||
| { | ||
| "id": "ca_ab_gst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "compound": true, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be FALSE? as Alberta doesn't have PST or is it to go with other taxes? If it should be TRUE then I think we need to do this to the ca_bc_gst too? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed, seems to me it should be false. |
||
| "amounts": [ | ||
| { | ||
| "id": "ca_ab_gst_standard_2013", | ||
| "amount": 0.05, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - British Columbia", | ||
| "generic_label": "GST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_bc_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "rates": [ | ||
| { | ||
| "id": "ca_bc_gst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_bc_gst_standard_2013", | ||
| "amount": 0.05, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - British Columbia", | ||
| "generic_label": "PST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_bc_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "rates": [ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should |
||
| { | ||
| "id": "ca_bc_pst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_bc_pst_standard_2013", | ||
| "amount": 0.07, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Manitoba", | ||
| "generic_label": "GST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_mb_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should |
||
| "rates": [ | ||
| { | ||
| "id": "ca_mb_gst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_mb_gst_standard_2013", | ||
| "amount": 0.05, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Manitoba", | ||
| "generic_label": "PST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_mb_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should |
||
| "rates": [ | ||
| { | ||
| "id": "ca_mb_pst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_mb_pst_standard_2013", | ||
| "amount": 0.08, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "name": "Canada - New Brunswick", | ||
| "generic_label": "HST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_nb_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "compound": false, | ||
| "rates": [ | ||
| { | ||
| "id": "ca_nb_hst_standard", | ||
| "name": "hst", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_nb_hst_standard_2013", | ||
| "amount": 0.13, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "name": "Canada - Newfoundland and Labrador", | ||
| "generic_label": "HST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_nl_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "rates": [ | ||
| { | ||
| "id": "ca_nl_hst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_nl_hst_standard_2013", | ||
| "amount": 0.13, | ||
| "start_date": "2013-04-01", | ||
| "end_date": "2015-12-31" | ||
| }, | ||
| { | ||
| "id": "ca_nl_hst_standard_2016", | ||
| "amount": 0.15, | ||
| "start_date": "2016-01-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Nova Scotia", | ||
| "generic_label": "HST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_ns_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "rates": [ | ||
| { | ||
| "id": "ca_ns_vat_standard", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd change to ca_ns_hst_standard to be consistent, and to get rid of vat. |
||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_ns_vat_standard_2013", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd change to ca_ns_hst_standard_2013 to be consistent, and to get rid of vat. |
||
| "amount": 0.15, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Northwest Territories", | ||
| "generic_label": "GST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_nt_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "rates": [ | ||
| { | ||
| "id": "ca_nt_gst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_nt_gst_standard_2013", | ||
| "amount": 0.05, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Nunavut", | ||
| "generic_label": "GST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_nu_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "rates": [ | ||
| { | ||
| "id": "ca_nu_gst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_nu_gst_standard_2013", | ||
| "amount": 0.05, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Ontario", | ||
| "generic_label": "HST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_on_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "rates": [ | ||
| { | ||
| "id": "ca_on_hst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_on_hst_standard_2013", | ||
| "amount": 0.13, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Prince Edward Island", | ||
| "generic_label": "HST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_pe_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "rates": [ | ||
| { | ||
| "id": "ca_pe_hst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_pe_hst_standard_2013", | ||
| "amount": 0.14, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Quebec", | ||
| "generic_label": "GST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_qc_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should |
||
| "rates": [ | ||
| { | ||
| "id": "ca_qc_gst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_qc_gst_standard_2013", | ||
| "amount": 0.05, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Quebec", | ||
| "generic_label": "QST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_qc_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should |
||
| "rates": [ | ||
| { | ||
| "id": "ca_qc_qst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_qc_qst_standard_2013", | ||
| "amount": 0.09975, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Saskatchewan", | ||
| "generic_label": "GST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_sk_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should |
||
| "rates": [ | ||
| { | ||
| "id": "ca_sk_gst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_sk_gst_standard_2013", | ||
| "amount": 0.05, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Saskatchewan", | ||
| "generic_label": "PST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_sk_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should |
||
| "rates": [ | ||
| { | ||
| "id": "ca_sk_pst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_sk_pst_standard_2013", | ||
| "amount": 0.05, | ||
| "start_date": "2013-04-01" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can probably be excluded? It's been 0.05 since October 28, 2006 http://finance.gov.sk.ca/taxes/pst/ |
||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "Canada - Yukon", | ||
| "generic_label": "GST", | ||
| "display_inclusive": false, | ||
| "zone": "ca_yt_vat", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove VAT everywhere in the system as that term is never used in Canada. |
||
| "tag": "CA", | ||
| "rates": [ | ||
| { | ||
| "id": "ca_yt_gst_standard", | ||
| "name": "Standard", | ||
| "default": true, | ||
| "amounts": [ | ||
| { | ||
| "id": "ca_yt_gst_standard_2013", | ||
| "amount": 0.05, | ||
| "start_date": "2013-04-01" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would be good to rename to remove vat |
||
| "name": "Canada - Alberta (GST)", | ||
| "scope": "tax", | ||
| "members": [ | ||
| { | ||
| "type": "country", | ||
| "id": "ca_ab_vat_0", | ||
| "name": "Canada - Alberta", | ||
| "country_code": "CA", | ||
| "administrative_area": "CA-AB" | ||
| } | ||
| ] | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering this is the default I'd suggest just removing it from all the json files (most of the others do it this way)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion :)
I'll have that done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I'd submit a pull request with your changes but it makes a new PR and would prefer if I could help on yours magically. (new to contrib on github)