FilterLists: add admin UI to enable/disable/edit entries and add additional entries#1735
Open
glaubinix wants to merge 16 commits into
Open
FilterLists: add admin UI to enable/disable/edit entries and add additional entries#1735glaubinix wants to merge 16 commits into
glaubinix wants to merge 16 commits into
Conversation
3bca50d to
886a8c0
Compare
886a8c0 to
74872ea
Compare
Contributor
Author
|
Apply fixes from #1768 |
Seldaek
reviewed
Jul 2, 2026
Seldaek
reviewed
Jul 2, 2026
Seldaek
reviewed
Jul 2, 2026
Seldaek
approved these changes
Jul 2, 2026
Seldaek
left a comment
Member
There was a problem hiding this comment.
Mostly good to go, few nitpicks and needs a rebase
Seldaek
reviewed
Jul 2, 2026
createdAt and exclude disabled entries from summary
… instead of ROLE_ADMIN for access check
07ff81e to
5cbe01d
Compare
Contributor
Author
Member
|
Sorry needs more rebase now :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires DB migrations
Before deploy
After deploy (sets publicId on all audit log entries which makes it possible to display matching entries on the edit view)
Design decisions
New filter list view
Shows all filter list entries with filters to better see what is going on. Disabled and overwritten entries are clearly marked in the UI.
New filter list edit view
Currently only allows you to modify the version constraint. All other properties are only shown for informational purposes.
The view shows at the bottom all audit log entries for the entry
Package filter list view changes
For admins there is now an edit link on the public page.
Audit/transparency log changes
New entries are created for admin actions visible to everyone.