Log partial payload + headers when a download is interrupted#228
Draft
yarikoptic wants to merge 1 commit into
Draft
Log partial payload + headers when a download is interrupted#228yarikoptic wants to merge 1 commit into
yarikoptic wants to merge 1 commit into
Conversation
When a streaming download fails mid-flight (ChunkedEncodingError / ConnectionError) or yields a corrupt zip, we now log the bytes written so far, the response headers, and a UTF-8/repr preview of the first 512 bytes of what arrived. This makes it possible to tell apart genuine truncation from a tiny error-stub response that the server returned with status 200. Motivated by intermittent IncompleteRead failures fetching GitHub Actions logs where the advertised Content-Length was suspiciously small (~4 KiB), but the discarded body could have revealed whether it was a JSON/HTML stub or real binary data. Co-Authored-By: Claude Code 2.1.119 / Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 55.45% 59.73% +4.28%
==========================================
Files 10 10
Lines 1421 1443 +22
Branches 222 223 +1
==========================================
+ Hits 788 862 +74
+ Misses 581 515 -66
- Partials 52 66 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a streaming download fails mid-flight (ChunkedEncodingError / ConnectionError) or yields a corrupt zip, we now log the bytes written so far, the response headers, and a UTF-8/repr preview of the first 512 bytes of what arrived. This makes it possible to tell apart genuine truncation from a tiny error-stub response that the server returned with status 200.
Motivated by intermittent IncompleteRead failures fetching GitHub Actions logs where the advertised Content-Length was suspiciously small (~4 KiB), but the discarded body could have revealed whether it was a JSON/HTML stub or real binary data.