Skip to content

Fixes #33034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jshirota wants to merge 1 commit into
base: main
Choose a base branch
from
+69 −0
Open

Fixes #33034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions recipes/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
{% set name = "glidergun" %}
{% set version = "0.9.127" %}

package:
name: {{ name|lower }}
version: {{ version }}
Comment on lines +4 to +6
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This recipe is placed at recipes/meta.yaml, but this repo expects each recipe to live in its own subdirectory (e.g. recipes/<recipe-name>/meta.yaml). Leaving a top-level recipes/meta.yaml will cause recipes/* linting and CI automation to treat it as a recipe path incorrectly. Please move this file to something like recipes/glidergun/meta.yaml (and keep any extra files like build scripts alongside it).

Copilot uses AI. Check for mistakes.

source:
url: https://github.com/jshirota/glidergun/archive/refs/tags/v0.9.127.tar.gz
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source.url is hard-coded to v0.9.127.tar.gz instead of using the version Jinja variable. This makes future version bumps error-prone (the version variable could be updated without updating the URL). Use v{{ version }} in the URL (and keep the sha256 in sync).

Suggested change
url: https://github.com/jshirota/glidergun/archive/refs/tags/v0.9.127.tar.gz
url: https://github.com/jshirota/glidergun/archive/refs/tags/v{{ version }}.tar.gz

Copilot uses AI. Check for mistakes.
sha256: a4589abaa63a25b1c590efa3ed8e9884674b446ef409b6137a36ea3d3d734254

build:
number: 0
skip: true # [py<310]

outputs:
- name: glidergun
script: "{{ PYTHON }} -m pip install . -vv"
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pip install command does not disable dependency resolution. In conda-forge builds this can cause pip to attempt to download/install dependencies from PyPI (which is disallowed / will fail in the offline build environment). Add --no-deps (and typically --no-build-isolation as well) to the pip install invocation.

Suggested change
script: "{{ PYTHON }} -m pip install . -vv"
script: "{{ PYTHON }} -m pip install . --no-deps --no-build-isolation -vv"

Copilot uses AI. Check for mistakes.
requirements:
host:
- python
- pip
- setuptools >=69
- wheel
run:
- python >=3.10
- contourpy >=1.3.2 # [py<311]
- contourpy >=1.3.3 # [py>=311]
- ipython >=8.39.0 # [py<311]
- ipython >=9.10.1 # [py>=311]
- matplotlib-base >=3.10.8
- numpy >=2.2.6 # [py<311]
- numpy >=2.4.4 # [py>=311]
- opencv >=4.13.0.92
- planetary-computer >=1.0.0
- rasterio >=1.4.4
- scikit-learn >=1.7.2 # [py<311]
- scikit-learn >=1.8.0 # [py>=311]
- scipy >=1.15.3 # [py<311]
- scipy >=1.17.1 # [py>=311]
- shapely >=2.1.2
test:
imports:
- glidergun
commands:
- python -c "import glidergun; print('glidergun import ok')"

- name: glidergun-torch
build:
noarch: generic
requirements:
run:
- python >=3.10
- glidergun =={{ version }}
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For multi-output recipes, depending on a sibling output via glidergun =={{ version }} does not pin the build string, so glidergun-torch could resolve against a different build of glidergun than the one produced by this recipe. Prefer using pin_subpackage('glidergun', exact=True) (or equivalent) to ensure the dependency matches both version and build.

Suggested change
- glidergun =={{ version }}
- {{ pin_subpackage('glidergun', exact=True) }}

Copilot uses AI. Check for mistakes.
Comment on lines +48 to +54
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glidergun-torch is marked noarch: generic, but the overall recipe is still built across the Python version matrix because the glidergun output is architecture-specific. That means this same noarch subpackage will be (re)built for every Python variant, likely producing identical noarch artifacts and causing upload/CI collisions. Consider adding an output-level skip selector (e.g. build it only on one Python version) so the noarch package is emitted once.

Copilot uses AI. Check for mistakes.
- pytorch >=2.7
- kornia >=0.8.2
test:
commands:
- python -c "import glidergun; print('glidergun-torch deps ok')"

about:
home: https://github.com/jshirota/glidergun
summary: Map Algebra with NumPy
license: MIT
license_file: LICENSE

extra:
recipe-maintainers:
- jshirota
Loading