Skip to content

Initial commit#33035

Open
jshirota wants to merge 1 commit intoconda-forge:mainfrom
jshirota:glidergun-recipe-update
Open

Initial commit#33035
jshirota wants to merge 1 commit intoconda-forge:mainfrom
jshirota:glidergun-recipe-update

Conversation

@jshirota
Copy link
Copy Markdown

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copilot AI review requested due to automatic review settings April 19, 2026 15:11
@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/meta.yaml) and found some lint.

Here's what I've got...

For recipes/meta.yaml:

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/24632225874. Examine the logs at this URL for more detail.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new conda-forge staged recipe for the glidergun project, including a companion meta-package (glidergun-torch) to install optional PyTorch/Kornia dependencies.

Changes:

  • Introduces recipes/meta.yaml defining a multi-output recipe for glidergun and glidergun-torch.
  • Adds runtime dependency constraints and basic import/command tests for both outputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread recipes/meta.yaml
version: {{ version }}

source:
url: https://github.com/jshirota/glidergun/archive/refs/tags/v0.9.127.tar.gz
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version Jinja variable is defined but not used in the source URL. Using v{{ version }} here avoids accidental mismatches when bumping the version later.

Suggested change
url: https://github.com/jshirota/glidergun/archive/refs/tags/v0.9.127.tar.gz
url: https://github.com/jshirota/glidergun/archive/refs/tags/v{{ version }}.tar.gz

Copilot uses AI. Check for mistakes.
Comment thread recipes/meta.yaml

outputs:
- name: glidergun
script: "{{ PYTHON }} -m pip install . -vv"
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding pip flags like --no-deps (and typically --no-build-isolation) to the install command so the build doesn’t try to resolve/install dependencies outside of conda during the recipe build.

Suggested change
script: "{{ PYTHON }} -m pip install . -vv"
script: "{{ PYTHON }} -m pip install . --no-deps --no-build-isolation -vv"

Copilot uses AI. Check for mistakes.
Comment thread recipes/meta.yaml
skip: true # [py<310]

outputs:
- name: glidergun
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name Jinja variable is defined but the output name is hard-coded. Using - name: {{ name|lower }} (or dropping the unused variable) reduces duplication and prevents future drift.

Suggested change
- name: glidergun
- name: {{ name|lower }}

Copilot uses AI. Check for mistakes.
Comment thread recipes/meta.yaml
requirements:
run:
- python >=3.10
- glidergun =={{ version }}
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the meta-package output, glidergun =={{ version }} pins only the version and not the build string. Using {{ pin_subpackage('glidergun', exact=True) }} (or an equivalent exact pin including build) helps ensure glidergun-torch always resolves to the matching build of glidergun.

Suggested change
- glidergun =={{ version }}
- {{ pin_subpackage('glidergun', exact=True) }}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants