Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/24632225874. Examine the logs at this URL for more detail. |
There was a problem hiding this comment.
Pull request overview
Adds a new conda-forge staged recipe for the glidergun project, including a companion meta-package (glidergun-torch) to install optional PyTorch/Kornia dependencies.
Changes:
- Introduces
recipes/meta.yamldefining a multi-output recipe forglidergunandglidergun-torch. - Adds runtime dependency constraints and basic import/command tests for both outputs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| version: {{ version }} | ||
|
|
||
| source: | ||
| url: https://github.com/jshirota/glidergun/archive/refs/tags/v0.9.127.tar.gz |
There was a problem hiding this comment.
The version Jinja variable is defined but not used in the source URL. Using v{{ version }} here avoids accidental mismatches when bumping the version later.
| url: https://github.com/jshirota/glidergun/archive/refs/tags/v0.9.127.tar.gz | |
| url: https://github.com/jshirota/glidergun/archive/refs/tags/v{{ version }}.tar.gz |
|
|
||
| outputs: | ||
| - name: glidergun | ||
| script: "{{ PYTHON }} -m pip install . -vv" |
There was a problem hiding this comment.
Consider adding pip flags like --no-deps (and typically --no-build-isolation) to the install command so the build doesn’t try to resolve/install dependencies outside of conda during the recipe build.
| script: "{{ PYTHON }} -m pip install . -vv" | |
| script: "{{ PYTHON }} -m pip install . --no-deps --no-build-isolation -vv" |
| skip: true # [py<310] | ||
|
|
||
| outputs: | ||
| - name: glidergun |
There was a problem hiding this comment.
The name Jinja variable is defined but the output name is hard-coded. Using - name: {{ name|lower }} (or dropping the unused variable) reduces duplication and prevents future drift.
| - name: glidergun | |
| - name: {{ name|lower }} |
| requirements: | ||
| run: | ||
| - python >=3.10 | ||
| - glidergun =={{ version }} |
There was a problem hiding this comment.
For the meta-package output, glidergun =={{ version }} pins only the version and not the build string. Using {{ pin_subpackage('glidergun', exact=True) }} (or an equivalent exact pin including build) helps ensure glidergun-torch always resolves to the matching build of glidergun.
| - glidergun =={{ version }} | |
| - {{ pin_subpackage('glidergun', exact=True) }} |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).