[LP-8094] Add deletion_protection support for kafka cluster #3318
Quality Gate passed
Annotations
Check failure on line 55 in internal/kafka/command_cluster_update.go
sonarqube-confluent / SonarQube Code Analysis
Define a constant instead of duplicating this literal "deletion-protection" 4 times.
[S1192] String literals should not be duplicated
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=c26c8c9f-3815-4b4c-89ee-e2c3bede020d&open=c26c8c9f-3815-4b4c-89ee-e2c3bede020d
Check failure on line 38 in internal/kafka/command_cluster_delete_test.go
sonarqube-confluent / SonarQube Code Analysis
Define a constant instead of duplicating this literal "Cluster deletion is blocked by deletion protection." 4 times.
[S1192] String literals should not be duplicated
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=823afd9b-9e81-4682-bc19-2b39ecacccc3&open=823afd9b-9e81-4682-bc19-2b39ecacccc3
Check failure on line 72 in internal/kafka/command_cluster_create.go
sonarqube-confluent / SonarQube Code Analysis
Define a constant instead of duplicating this literal "deletion-protection" 3 times.
[S1192] String literals should not be duplicated
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=211dac99-2ba5-459e-bb90-3ec1b2721bd6&open=211dac99-2ba5-459e-bb90-3ec1b2721bd6
Check failure on line 132 in test/test-server/cmk_handlers.go
sonarqube-confluent / SonarQube Code Analysis
Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.
[S3776] Cognitive Complexity of functions should not be too high
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=9ebb1fad-6488-40b2-9269-bad22a2d0519&open=9ebb1fad-6488-40b2-9269-bad22a2d0519
Check failure on line 237 in test/test-server/cmk_handlers.go
sonarqube-confluent / SonarQube Code Analysis
Define a constant instead of duplicating this literal "kafka-cluster" 8 times.
[S1192] String literals should not be duplicated
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=f096b76d-040f-4b8a-ba39-fd4f86b60b64&open=f096b76d-040f-4b8a-ba39-fd4f86b60b64
Check failure on line 66 in internal/kafka/command_cluster_update.go
sonarqube-confluent / SonarQube Code Analysis
Refactor this method to reduce its Cognitive Complexity from 45 to the 15 allowed.
[S3776] Cognitive Complexity of functions should not be too high
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=2d029223-029d-474d-9b46-80633de59e4c&open=2d029223-029d-474d-9b46-80633de59e4c
Check failure on line 19 in test/test-server/cmk_handlers.go
sonarqube-confluent / SonarQube Code Analysis
Refactor this method to reduce its Cognitive Complexity from 50 to the 15 allowed.
[S3776] Cognitive Complexity of functions should not be too high
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=e43ba358-ace7-49e9-9877-0743c4a0e7b7&open=e43ba358-ace7-49e9-9877-0743c4a0e7b7
Check failure on line 85 in internal/kafka/command_cluster_create.go
sonarqube-confluent / SonarQube Code Analysis
Refactor this method to reduce its Cognitive Complexity from 40 to the 15 allowed.
[S3776] Cognitive Complexity of functions should not be too high
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=de54829c-7fd9-4178-8c58-e2143ee0c141&open=de54829c-7fd9-4178-8c58-e2143ee0c141
Check failure on line 53 in internal/kafka/command_cluster_update.go
sonarqube-confluent / SonarQube Code Analysis
Define a constant instead of duplicating this literal "max-ecku" 4 times.
[S1192] String literals should not be duplicated
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=53dcc62d-ff31-4f63-924d-d8d1aaf9a097&open=53dcc62d-ff31-4f63-924d-d8d1aaf9a097
Check failure on line 348 in test/test-server/cmk_handlers.go
sonarqube-confluent / SonarQube Code Analysis
Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed.
[S3776] Cognitive Complexity of functions should not be too high
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=59e49fa8-b709-4dcc-84be-c4222498abfa&open=59e49fa8-b709-4dcc-84be-c4222498abfa
Check warning on line 111 in internal/kafka/command_cluster_delete.go
sonarqube-confluent / SonarQube Code Analysis
Remove this unnecessary variable declaration and use the expression directly in the condition.
[S8193] Variables in if short statements should be used beyond just the condition
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3318&issues=99d01350-8cb5-471a-9280-1d42436211fa&open=99d01350-8cb5-471a-9280-1d42436211fa