fix(policies): send the empty list when the picker is cleared - #21
Merged
Conversation
Clearing the capability or level picker used to drop the key entirely, so the stored mask survived the save and the requirement could never be removed from the UI. Now that the parser folds an empty list to the zero mask, the picker passes the selection through as-is.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clearing the capability/level picker used to drop the key from the payload (
onChange(next.length > 0 ? next : undefined)), so the stored mask survived the save — a requirement could never be removed from the UI. The picker now passes the selection through as-is, so a cleared picker sends[].Pairs with constructive-io/constructive-db#2994, where
*_get_mask_by_namesfolds the empty list to the zero mask instead of returning NULL (which previously made[]throwINTERNAL_ERROR). Under the subset test a zero mask means "any member of the scope", which is exactly what an empty selection says.Link to Devin session: https://app.devin.ai/sessions/8f89acc9280e4cef880921d966e0e8fc
Requested by: @pyramation