fix(pg-codegen): read unqualified on an empty where, refuse an empty write filter - #1734
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A call site that qualifies a read with a conditional key column — the shape every scoped module read takes — states an empty filter when the scope records no key:
The generated client passed that straight to
QueryBuilder.where({}), which throwsEmpty filter object., so the global-scope path of every such read failed at runtime rather than reading unqualified.The client now distinguishes "no predicate" from "no rows asked for":
and because the same emptiness on a write would silently mean every row,
update/deleteroute throughrequired(where, op)and throw instead:findMany/findFirst/countread unqualified;update/deletethrow. Two live round-trip tests cover both, and the committed__fixtures__/generated/client.tsis regenerated.Link to Devin session: https://app.devin.ai/sessions/b1fb8d90ec0a4cd1bd95e3c77c6f6680
Requested by: @pyramation