fix: remove comment from bake-action set input#448
Conversation
docker/bake-action's set input is a plain newline-separated list of target.key=value overrides, not YAML — it doesn't understand '#' comments on their own line. The explanatory comment added in #447 was fed straight into `docker buildx bake --set`, which failed to parse it and broke every build job in release/20260705: cannot parse bake definitions: ERROR: invalid override key # don't push tags; ..., expected target.name Moved the explanation to a real YAML comment above the step instead.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change relocates and rewords explanatory comments in the GitHub Actions publish workflow surrounding the per-platform "build and push by digest" step, clarifying that tags are cleared during build and applied later in a merge job to avoid a race condition. No functional behavior changes. ChangesPublish Workflow Comment Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes the failure in release/20260705, the first release run after #447 merged.
docker/bake-action'ssetinput is a plain newline-separated list oftarget.key=valueoverrides, not YAML — each line is passed straight todocker buildx bake --set. The explanatory comment added during #447's review (a#-prefixed line inside theset: |block) isn't a comment tobake --set, it's an invalid override key, and it broke every one of the 36 build jobs identically:Moved the explanation to a real YAML comment above the step (outside the block scalar), where it can't be fed into
bake --set.Validation
docker buildx bake --print ... --set "# don't push tags..."throws the identicalinvalid override keyerror.actionlintandzizmorpass clean.Test plan
AI Disclosure
Per the project's AI-Assisted Contribution Policy:
bake-actionsetblock scalar).invalid override keyerror locally against the realdocker-bake.hclbefore writing the fix, then confirmed the correctedsetblock resolves cleanly with the same local reproduction.actionlintandzizmorboth pass clean.Summary by CodeRabbit