fix: refresh mempool caches every block - #1245
Open
mmsqe wants to merge 4 commits into
Open
Conversation
call NotifyNewBlock unconditionally from EndBlock, made idempotent per head so two drivers cannot emit duplicate chain head events dedup chain head events per committed height
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1245 +/- ##
==========================================
+ Coverage 67.41% 67.43% +0.02%
==========================================
Files 320 320
Lines 23451 23473 +22
==========================================
+ Hits 15810 15830 +20
- Misses 6459 6461 +2
Partials 1182 1182
🚀 New features to boost your workflow:
|
mmsqe
marked this pull request as ready for review
July 31, 2026 09:56
Contributor
|
PR author is not in the allowed authors list. |
3 tasks
* check the height hint before notifyMu (atomic), so a losing driver does not wait out the winner's feed delivery just to skip * return the announced header (nil when nothing was sent), so recheck reuses it instead of rebuilding via CurrentBlock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NotifyNewBlockrefreshes mempool's cached context, butevmd/mempool.goonly called it without an event bus — so with one, theSetEventBusgoroutine was the sole driver, and it exits for good when CometBFT cancels a lagging subscriber, leaving the context stuck.Drop
!HasEventBus()gate soPrepareCheckState, which runs every block fromCommit, always drives the refresh.NotifyNewBlockis made safe for two drivers: it refreshes before a per-height dedup and returns whether it emitted an event so the recheck reruns only when height advanced.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch