Skip to content

feat(collection): adjust some visuals of collection, i.e. gap, trash … - #4631

Merged
FelixBlaisThon merged 7 commits into
masterfrom
ADUI-11567-collection-legacy-visual-review
Oct 8, 2026
Merged

FelixBlaisThon merged 7 commits into
masterfrom
ADUI-11567-collection-legacy-visual-review

Conversation

@FelixBlaisThon

Copy link
Copy Markdown
Contributor

…icon, padding and alignement center

Proposed Changes

  • General spacing and padding from 24px to 16px
  • ‘Draggable’ icon height set to 36px
  • ‘Remove’ ActionIcon size set to ‘lg’ (36px x 36px)
  • Center align items vertically

before:

(Legacy)
image

image

After:

(Legacy)
image

image

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • A changeset is added for releasable changes, following CONTRIBUTING.md
  • README.md is adjusted to reflect the proposed changes (if relevant)

Copilot AI balanced review requested due to automatic review settings October 2, 2026 19:23
@FelixBlaisThon
FelixBlaisThon requested a review from a team as a code owner October 2, 2026 19:23
@FelixBlaisThon
FelixBlaisThon requested review from GermainBergeron and gdostie and removed request for a team October 2, 2026 19:23
@svcsnykcoveo

svcsnykcoveo commented Oct 2, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Release Preview

This PR would bump 1 package version if it were merged and released from master.

Patch

Package Next
@coveord/plasma-mantine 61.3.3

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Live demo of your latest successful build available here:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The control spacer, public documentation, and release changeset must be updated.

Review effort: Balanced
Findings: 1 Medium severity · 2 Low severity

Open (3)
What changed in this PR

Updates Collection spacing and control alignment for a more compact layout.

Changes:

  • Reduces default gaps and container padding.
  • Centers collection items vertically.
  • Enlarges drag and remove controls.
File Description
Collection.tsx Changes the default item gap to sm.
Collection.module.css Adjusts padding, alignment, and drag-handle height.
RemoveButton.tsx Enlarges the remove action.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/mantine/src/components/Collection/layouts/shared/RemoveButton.tsx Outdated
Comment thread packages/mantine/src/components/Collection/Collection.module.css
Comment thread packages/mantine/src/components/Collection/Collection.tsx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread packages/mantine/src/components/Collection/layouts/shared/RemoveButton.tsx Outdated
Comment thread packages/mantine/src/components/Collection/Collection.module.css Outdated
@FelixBlaisThon
FelixBlaisThon requested a review from gdostie October 6, 2026 17:24
@FelixBlaisThon
FelixBlaisThon enabled auto-merge (squash) October 7, 2026 20:29
Comment thread packages/storybook/src/components/forms-and-inputs/array/Collection.stories.tsx Outdated
@FelixBlaisThon
FelixBlaisThon merged commit 78f8826 into master Oct 8, 2026
15 of 17 checks passed
@FelixBlaisThon
FelixBlaisThon deleted the ADUI-11567-collection-legacy-visual-review branch October 8, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants