Skip to content

feat(appshell): +aside in the storybook demo, +toggles - #4633

Merged
FelixBlaisThon merged 2 commits into
masterfrom
ADUI-11550-appshell-improvements
Oct 8, 2026
Merged

FelixBlaisThon merged 2 commits into
masterfrom
ADUI-11550-appshell-improvements

Conversation

@FelixBlaisThon

@FelixBlaisThon FelixBlaisThon commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

Added new controls in the storybook demo to collapse (or not) the Navigation or the Aside component of the Appshell

Screen.Recording.2026-10-06.at.1.23.36.PM.mov

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • A changeset is added for releasable changes, following CONTRIBUTING.md
  • README.md is adjusted to reflect the proposed changes (if relevant)

@svcsnykcoveo

svcsnykcoveo commented Oct 6, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Release Preview

This PR would not change any package versions if it were merged and released from master.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Live demo of your latest successful build available here:

@FelixBlaisThon
FelixBlaisThon marked this pull request as ready for review October 6, 2026 17:24
@FelixBlaisThon
FelixBlaisThon requested a review from a team as a code owner October 6, 2026 17:24
@FelixBlaisThon
FelixBlaisThon requested review from GermainBergeron and gdostie and a balanced review from Copilot and removed request for a team October 6, 2026 17:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new controls need complete metadata, and imports should consistently use the public package root.

Review effort: Balanced
Findings: 2 Low severity

Open (2)
What changed in this PR

Adds AppShell Storybook controls for independently collapsing the navbar and aside.

Changes:

  • Adds an aside with configurable width.
  • Adds navbar and aside collapse toggles.
  • Replaces a direct Mantine import with Plasma exports.
File Description
packages/​storybook/​src/​components/​layout/​AppShell.stories.tsx Expands the AppShell demo and controls.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/storybook/src/components/layout/AppShell.stories.tsx Outdated
Comment thread packages/storybook/src/components/layout/AppShell.stories.tsx
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@FelixBlaisThon
FelixBlaisThon enabled auto-merge (squash) October 7, 2026 17:44
@FelixBlaisThon
FelixBlaisThon requested a review from gdostie October 7, 2026 17:44
@FelixBlaisThon
FelixBlaisThon merged commit b782440 into master Oct 8, 2026
15 of 17 checks passed
@FelixBlaisThon
FelixBlaisThon deleted the ADUI-11550-appshell-improvements branch October 8, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants