Repository navigation
feat(appshell): +aside in the storybook demo, +toggles - #4633
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Release PreviewThis PR would not change any package versions if it were merged and released from |
Contributor
|
Live demo of your latest successful build available here: |
FelixBlaisThon
marked this pull request as ready for review
October 6, 2026 17:24
FelixBlaisThon
requested review from
GermainBergeron and
gdostie
and
a balanced review from Copilot
and removed request for
a team
October 6, 2026 17:24
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new controls need complete metadata, and imports should consistently use the public package root.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds AppShell Storybook controls for independently collapsing the navbar and aside.
Changes:
- Adds an aside with configurable width.
- Adds navbar and aside collapse toggles.
- Replaces a direct Mantine import with Plasma exports.
| File | Description |
|---|---|
packages/storybook/src/components/layout/AppShell.stories.tsx |
Expands the AppShell demo and controls. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gdostie
approved these changes
Oct 7, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
FelixBlaisThon
enabled auto-merge (squash)
October 7, 2026 17:44
gdostie
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed Changes
Added new controls in the storybook demo to collapse (or not) the
Navigationor theAsidecomponent of theAppshellScreen.Recording.2026-10-06.at.1.23.36.PM.mov
Potential Breaking Changes
Acceptance Criteria