Repository navigation
feat(mantine): add footer and toggle options to Navigation.SideBar (ADUI-11614) - #4634
Draft
GermainBergeron wants to merge 1 commit into
Draft
GermainBergeron wants to merge 1 commit into
GermainBergeron wants to merge 1 commit into
Conversation
…DUI-11614) Navigation.SideBar accepts a `footer` pinned below the scrollable links, `withToggle` to remove the collapse toggle, and `toggleProps` to customize it. Navigation.Toggle gets a `disabled` prop and toggles when its whole strip is clicked, not only the chevron button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Release PreviewThis PR would bump 1 package version if it were merged and released from Minor
|
Contributor
|
Live demo of your latest successful build available here: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Admin-UI is moving its navigation onto Plasma's
Navigation(coveo-platform/admin-ui#21424). It currently has to portal its footer into the sidebar and hide the collapse toggle with a CSS selector tied to Plasma's DOM (markedTODO: ADUI-11614there).Navigation.SideBarnow accepts a footer and can remove or disable its collapse toggle, so those workarounds can go away. The toggle also reacts to clicks along the whole sidebar edge again, like the admin-ui toggle it came from.To try it: in the Storybook preview, play with the new controls of Layout / Navigation / Demo.
Potential Breaking Changes
None. Clicking next to the chevron now toggles the sidebar too.
Acceptance Criteria
🤖 Generated with Claude Code