Repository navigation
fix(mantine, collection): align horizontal rows on baseline - #4635
Closed
GermainBergeron wants to merge 2 commits into
Closed
GermainBergeron wants to merge 2 commits into
GermainBergeron wants to merge 2 commits into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Release PreviewThis PR would bump 1 package version if it were merged and released from Patch
|
Contributor
|
Live demo of your latest successful build available here: |
GermainBergeron
changed the title
GermainBergeron
marked this pull request as ready for review
October 8, 2026 00:17
GermainBergeron
requested review from
FelixBlaisThon and
gdostie
and
a balanced review from Copilot
and removed request for
a team
October 8, 2026 00:17
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The CSS changes are scoped appropriately and the Chromatic story covers the reported alignment regression.
0 open findings
What changed in this PR
Fixes horizontal Collection row alignment when validation errors appear.
Changes:
- Baseline-aligns horizontal rows and offsets action controls.
- Adds a hidden Chromatic validation-error story.
- Adds a patch changeset.
| File | Description |
|---|---|
Collection.stories.tsx |
Adds validation examples and visual coverage. |
VerticalLayout.module.css |
Preserves vertical control positioning. |
HorizontalLayout.module.css |
Baseline-aligns horizontal rows. |
Collection.module.css |
Centers row action controls. |
.changeset/collection-row-baseline.md |
Documents the user-facing fix. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In the horizontal
Collectionlayout, a validation error no longer pushes the rest of the row down. Rows align on baseline, and the drag handle and trash button stay centered on the inputs.New hidden
CollectionValidationErrorsstory for Chromatic.Potential Breaking Changes
None. Legacy layout handle and trash move 3px down.
Acceptance Criteria