Skip to content

fix(collection): add spacing above the add item button in column layouts - #4636

Merged
GermainBergeron merged 1 commit into
masterfrom
fix-collection-add-button-spacing
Oct 8, 2026
Merged

GermainBergeron merged 1 commit into
masterfrom
fix-collection-add-button-spacing

Conversation

@GermainBergeron

Copy link
Copy Markdown
Member

Proposed Changes

Adds 16px (--mantine-spacing-sm) between the last row and the Add item button of Collection column layouts, which previously had no spacing. The legacy (children) layout is unchanged since its gap already spaces the button.

Potential Breaking Changes

None.

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • A changeset is added for releasable changes, following CONTRIBUTING.md (covered by gentle-comets-wander.md)
  • README.md is adjusted to reflect the proposed changes (if relevant)

@svcsnykcoveo

svcsnykcoveo commented Oct 8, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Release Preview

Warning: Changesets detected package changes since origin/master, but no changeset file was found.

As-is, merging this PR would not publish a new package version. Run pnpm changeset to declare the intended release, or add an empty changeset if the package changes do not need a release.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Live demo of your latest successful build available here:

@GermainBergeron
GermainBergeron marked this pull request as ready for review October 8, 2026 20:39
@GermainBergeron
GermainBergeron requested a review from a team as a code owner October 8, 2026 20:39
@GermainBergeron
GermainBergeron requested review from FelixBlaisThon and gdostie and a balanced review from Copilot and removed request for a team October 8, 2026 20:39
@GermainBergeron
GermainBergeron enabled auto-merge (squash) October 8, 2026 20:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new spacing behavior lacks the required test coverage.

1 open finding
What changed in this PR

Adds spacing between column-layout rows and the Collection add-item button while preserving legacy layout spacing.

Changes:

  • Adds sm top margin to direct-child add-button containers.
  • Limits the rule to column layouts.
File Description
Collection.module.css Adds column-layout add-button spacing.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/mantine/src/components/Collection/Collection.module.css
@GermainBergeron
GermainBergeron merged commit fbbde68 into master Oct 8, 2026
19 of 20 checks passed
@GermainBergeron
GermainBergeron deleted the fix-collection-add-button-spacing branch October 8, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants