Skip to content

ci(chromatic): ignore orphaned unaffected baselines #8392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louis-bompart merged 2 commits into from
Aug 27, 2026
Merged

ci(chromatic): ignore orphaned unaffected baselines #8392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e1ce3e
ci(chromatic): ignore orphaned unaffected baselines
louis-bompart Aug 27, 2026
100935f
ci(chromatic): preserve baseline on affected failure
louis-bompart Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ jobs:

chromatic:
name: 'Run Chromatic visual tests on Atomic'
needs: [build]
needs: [affected, build]
if: ${{ always() && !cancelled() }} # Run even if build is skipped
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -434,6 +434,11 @@ jobs:
(!startsWith(github.head_ref, 'renovate/') ||
contains(fromJSON(vars.CHROMATIC_RENOVATE_ALLOWLIST || '[]'), github.head_ref))
with:
# Unaffected PRs should have one reachable baseline so unchanged Storybooks use
# TurboSnap bypass pricing. If affected calculation fails, keep normal baseline selection.
# Reachable same-branch builds are still found in Git history; this only drops Chromatic's
# continuity fallback for an orphaned branch build.
ignoreLastBuildOnBranch: ${{ needs.affected.result == 'success' && !contains(needs.affected.outputs.tasks, '"@coveo/atomic#build"') && github.head_ref || '' }}
Comment thread
louis-bompart marked this conversation as resolved.
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
workingDir: packages/atomic
- name: Skip Chromatic visual tests
Expand Down
Loading