Repository navigation
fix(demo-schema-react): share the related document list j:SVCC-6608 - #8714
dguerinCoveo wants to merge 3 commits into
Conversation
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
commit: |
|
Tip All tests passed and all changes approved!🟢 UI Tests: 439 tests unchanged |
There was a problem hiding this comment.
🟡 Changes recommended
The new type import is unavailable in the pinned schema release, leaving TypeScript checking broken.
1 open issue
What changed in this PR
Extracts the research card’s related-document list for reuse by the upcoming comparison-table feature.
Changes:
- Shares document rendering, filtering, limits, size formatting, and styles.
- Restricts document links to HTTP(S).
- Adds coverage for non-HTTP(S) links and
NaNlimits.
| File | Description |
|---|---|
| samples/thermidor/demo-schema-react/src/a2ui/RelatedDocuments/RelatedDocumentList.tsx | Adds shared rendering and document helpers. |
| samples/thermidor/demo-schema-react/src/a2ui/RelatedDocuments/RelatedDocumentList.module.css | Houses extracted document-row styles. |
| samples/thermidor/demo-schema-react/src/a2ui/ProductResearchCard/ProductResearchCard.tsx | Uses the shared list and helpers. |
| samples/thermidor/demo-schema-react/src/a2ui/ProductResearchCard/ProductResearchCard.test.tsx | Updates imports and adds edge-case coverage. |
| samples/thermidor/demo-schema-react/src/a2ui/ProductResearchCard/ProductResearchCard.module.css | Removes extracted list styles. |
Review effort: Balanced
The research card's document rows move into RelatedDocumentList so the comparison table can reuse them. Links now open only http(s) URIs; any other scheme shows the title as plain text, as the design requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…om the schema thermidor-schema#173 exports the shared document type from the package root, so the list no longer derives it from ProductResearchCardState. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
29247e7 to
e45e897
Compare

Jira
https://coveord.atlassian.net/browse/SVCC-6608
Motivation
The research card's list of related documents becomes a shared component, so the comparison table in #8712 can reuse it. Links now open only http(s) URIs, as the rich content grounding design requires.
Changes
RelatedDocumentListholds the rows, the size format, themaxLinksrule and which documents to show. The research card uses it with no visible change.clickUriisn't http(s) shows its title as plain text instead of a link. This changes the research card from #8675.ProductResearchRelatedDocumentfrom@coveo/thermidor-schema.Details
@coveo/thermidor-schema1.0.0-beta.30, pinned in #8713.Validation
pnpm exec vitest runinsamples/thermidor/demo-schema-react. The research card tests pass, including ajavascript:link rendered as text.Checklist
feat(<scope>): <description>)pnpm changeset) if modifying public package source code. Not applicable: the sample is private.🤖 Generated with Claude Code