Skip to content

ROCm Compile Time Reduction#966

Open
Spaarsh wants to merge 2 commits into
cp2k:developfrom
Spaarsh:develop
Open

ROCm Compile Time Reduction#966
Spaarsh wants to merge 2 commits into
cp2k:developfrom
Spaarsh:develop

Conversation

@Spaarsh

@Spaarsh Spaarsh commented Oct 18, 2025

Copy link
Copy Markdown

As per #933 discussion, this PR attempts to reduce compile time for rocm-enabled dbcsr builds with multiple target architectures.

@Spaarsh

Spaarsh commented Oct 18, 2025

Copy link
Copy Markdown
Author

Currently, cmake successfully but make results in a failure with these errors:

In file included from /dbcsr/src/acc/cuda_hip/acc_mem.cpp:13:
/dbcsr/src/acc/cuda_hip/acc_mem.cpp: In function 'int c_dbcsr_acc_host_mem_allocate(void**, size_t, void*)':
/dbcsr/src/acc/cuda_hip/../hip/acc_hip.h:23:16: error: 'hipHostAllocDefault' was not declared in this scope; did you mean 'hipHostMallocDefault'?
   23 | #define ACC(x) hip##x
      |                ^~~
/dbcsr/src/acc/cuda_hip/acc_mem.cpp:49:23: note: in expansion of macro 'ACC'
   49 |   unsigned int flag = ACC(HostAllocDefault);
      |                       ^~~

@alazzaro alazzaro self-requested a review October 19, 2025 18:17
@alazzaro

Copy link
Copy Markdown
Member

Thanks for your contribution.
However, given the current problems, I will keep this PR for a new release of DBCSR.

@Growl1234

Copy link
Copy Markdown
Contributor

@Spaarsh Is there any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants