Skip to content

[mdspan.sub.sub] Fix submdspan slice canonicalization #8996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkoeppe merged 1 commit into from
May 12, 2026
Merged

[mdspan.sub.sub] Fix submdspan slice canonicalization #8996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/containers.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21297,7 +21297,7 @@
class AccessorPolicy, class... SliceSpecifiers>
constexpr auto submdspan(
const mdspan<ElementType, Extents, LayoutPolicy, AccessorPolicy>& src,
SliceSpecifiers... slices) -> @\seebelow@;
SliceSpecifiers... raw_slices) -> @\seebelow@;
Copy link
Copy Markdown
Member

@jwakely jwakely May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been changed by the paper, to match the change to [mdspan.sub.sub] in the paper.


template<class T, class IndexType>
concept @\defexposconcept{index-pair-like}@ = // \expos
Expand Down Expand Up @@ -26579,7 +26579,7 @@
class AccessorPolicy, class... SliceSpecifiers>
constexpr auto submdspan(
const mdspan<ElementType, Extents, LayoutPolicy, AccessorPolicy>& src,
SliceSpecifiers... slices) -> @\seebelow@;
SliceSpecifiers... raw_slices) -> @\seebelow@;
Copy link
Copy Markdown
Member

@jwakely jwakely May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just a misapplication of the paper. https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p3663r3.html#change-mdspan.sub.sub-submdspan-function-template said to change this.

Copy link
Copy Markdown
Contributor

@tkoeppe tkoeppe May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

\end{itemdecl}

\begin{itemdescr}
Expand All @@ -26589,7 +26589,7 @@
\pnum
Let \tcode{slices} be the pack introduced by the following declaration:
\begin{codeblock}
auto [...slices] = canonical_slices(src, raw_slices...);
auto [...slices] = canonical_slices(src.extents(), raw_slices...);
Copy link
Copy Markdown
Member

@jwakely jwakely May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug in the paper.

\end{codeblock}

\pnum
Expand Down
Loading