Repository navigation
! change: Replace deprecated FakeConnector with new implementation - #36
Merged
remipelhate merged 6 commits intoOct 7, 2026
Conversation
remipelhate
added
type: change
concern: breaking
This reverts commit e842f10.
It is still heavily used in some codebases. Removing it in v2 would cause to much upgrade burden.
remipelhate
deleted the
change/replace-deprecated-fake-connector-with-new-implementation
branch
October 7, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This PR contains breaking changes.
Breaking Changes
Craftzing\TestBench\Saloon\Doubles\FakeConnectorfrom v1 has been renamed toCraftzing\TestBench\Saloon\Doubles\StubConnectorCraftzing\TestBench\Saloon\Doubles\FakeResponseConnectorfrom v1.3 has been renamed toCraftzing\TestBench\Saloon\Doubles\FakeConnector