Skip to content

build: Use the shared crossplane cachix cache in nix.sh#17

Open
adamwg wants to merge 1 commit into
crossplane:mainfrom
adamwg:awg/cachix
Open

build: Use the shared crossplane cachix cache in nix.sh#17
adamwg wants to merge 1 commit into
crossplane:mainfrom
adamwg:awg/cachix

Conversation

@adamwg
Copy link
Copy Markdown
Member

@adamwg adamwg commented May 20, 2026

Description of your changes

Our CI is already pushing to the org-wide cachix cache called crossplane. Update nix.sh to use this cache rather than the non-existent one called crossplane-cli.

I have:

Our CI is already pushing to the org-wide cachix cache called
`crossplane`. Update nix.sh to use this cache rather than the non-existent one
called `crossplane-cli`.

Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
@adamwg adamwg requested review from a team, jcogilvie and tampakrap as code owners May 20, 2026 21:27
@adamwg adamwg requested review from jbw976 and removed request for a team May 20, 2026 21:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a26efb8d-62ac-47a3-a6d9-75fcca7646dd

📥 Commits

Reviewing files that changed from the base of the PR and between bc59509 and e0077c7.

📒 Files selected for processing (1)
  • nix.sh

📝 Walkthrough

Walkthrough

The PR updates the Nix binary cache configuration in the Docker container setup to use crossplane.cachix.org instead of crossplane-cli.cachix.org, including the corresponding public key update for cache authentication.

Changes

Cachix Binary Cache Configuration

Layer / File(s) Summary
Nix binary cache endpoint and keys update
nix.sh
The Cachix substituter URL in extra-substituters and the corresponding trusted public key in extra-trusted-public-keys are updated from crossplane-cli.cachix.org to crossplane.cachix.org.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Breaking Changes ❌ Error Files under apis/** and cmd/** add new required public fields (e.g., Project struct in project_types.go with required Spec field) without a 'breaking-change' label. Add 'breaking-change' label to the PR, or clarify the scope of the check to exclude initial repository setup commits with only newly added files.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and descriptively summarizes the main change: updating nix.sh to use the shared crossplane cachix cache instead of the non-existent one.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation (CI already pushes to org-wide cache) and the specific update being made (switching from crossplane-cli to crossplane cache).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Feature Gate Requirement ✅ Passed PR updates nix.sh Cachix cache configuration from non-existent to organization-wide cache. This is a build infrastructure fix, not a new experimental feature requiring feature gates.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant