Repository navigation
fix(core): surface application errors returned through the applications proxy - #736
Merged
Merged
Conversation
…ns proxy
Errors an application returns through /applications/{identifier}/api/{path}
arrive with the application's status code and body wrapped in Crowdin's
`data` envelope. handleHttpClientError only read the top-level `error` or
`errors` members, so these surfaced as "Request failed with status code N"
and the application's message was lost.
Read the envelope when Crowdin's own members are absent: the thrown
CrowdinError carries the application's message, its numeric code or else
the HTTP status, and the whole body in `apiError` so callers can tell an
application error from a Crowdin one.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 88.88% 88.92% +0.05%
==========================================
Files 46 47 +1
Lines 2543 2563 +20
Branches 340 350 +10
==========================================
+ Hits 2260 2279 +19
Misses 85 85
- Partials 198 199 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
@yevheniyJ PTAL |
yevheniyJ
reviewed
Oct 8, 2026
Move CrowdinError, CrowdinValidationError, handleHttpClientError and their helpers from core/index.ts to core/error-handling.ts. core/index.ts re-exports the module, so the public exports are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yevheniyJ
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors an application returns through
/applications/{identifier}/api/{path}arrive with the application's status code and body wrapped in Crowdin'sdataenvelope.handleHttpClientErroronly read the top-levelerrororerrorsmembers, so these surfaced as "Request failed with status code N" and the application's message was lost.Read the envelope when Crowdin's own members are absent: the thrown CrowdinError carries the application's message, its numeric code or else the HTTP status, and the whole body in
apiErrorso callers can tell an application error from a Crowdin one.