feat: add configuration dataclass, allow squelching duplicate name warnings#149
Merged
Conversation
…rnings BREAKING CHANGE: The OmniLogic class now accepts a single configuration parameter which is an instance of OmniLogicConfiguration. The host to connect to must now be passed as a parameter from OmniLogicConfiguration. This allows more advanced configuration of the library to support future functionality.
cryptk
force-pushed
the
feat_class_configuration
branch
from
2d45357 to
16eb54b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The OmniLogic class now accepts a single configuration parameter which is an instance of OmniLogicConfiguration. The host to connect to must now be passed as a parameter from OmniLogicConfiguration. This allows more advanced configuration of the library to support future functionality.
@moveslikeyoda and @tonyfruzza I know you two are using the library directly, so heads up... Luckily, the change will be easy. Rather than doing something like:
Just do:
I know it adds an extra line, but this gives me a much more sane way to manage the (soon to be) expanding configuration of the library.